c++ - Stack with push and pop functions not working -


this program.

#include<iostream> #include<string>  using namespace std;  struct stack {     int inf;     stack* link; } *start, *p;  void push(stack*, stack*, int); void pop(stack*, stack*);  int main() {     int s = 0;     string thing;      cin >> thing;     while (thing != "end")     {         if (thing == "push")         {             push(start, p, s);         }         if (thing == "pop")         {             pop(start, p);         }         cin >> thing;     }     return 0;  }  void push(stack *start, stack *p, int s) {          cin >> s;          p = start;         start = new stack;         start->inf = s;         start->link = p;          cout << "pushed " << start->inf << endl; }  void pop(stack *start, stack *p) {       cout << "popped " << start->inf;     p = start;     start = start->link;     delete p;   }

it's simple program allow me push , pop items , stack, reason pop() won't work. if add if(start) before pop skips it, making me think stack somehow becomes null after push completed. works until reaches cout << "popped " << start->inf; line, when crashes (no error message) again makes me think stack becomes null before reaches pop(). suggestions?

first, both of function's signature weird:

void push(stack *start, stack *p, int s) void pop(stack *start, stack *p)

assuming start points top of stack, should discard p. should local variable function, not parameter.

second, let's see push implementation:

p = start; start = new stack; start->inf = s; start->link = p;

this 1 looks good. missed start declared pointer stack, , changing pointer inside function, value parameter instead of reference. current signature, can change start points to, not start itself. can either declare pointer pointer stack, , change body accordingly (you need double dereference assigning inf , link) or use reference parameter adding & before parameter name. same case applies pop function.


Comments

Post a Comment

Popular posts from this blog

c# - Validate object ID from GET to POST -

i have method allows user access comment have made on site. have post method lets them update comment. my normal solution send entire comment model through, let them update it, update on database when post back. involve sending commentid through in hiddenfor , can manipulated. how can verify commentid sent in get method same i'm getting in post , not able alter comment wish? how can verify commentid sent in method same i'm getting in post? basically have validate following things in post - user logged-in user. authenticated users post comments. commentid in post , should valid commentid , should present in database. userid associated logged-in user should same userid associated comment . comment should contain userid column, can check @ time of update. to make sure update happens comment has been sent in get - hold commentid in session , in post action compare commentid value in session .
Read more

node.js - Custom Model Validator SailsJS -

when using custom model validator checks record within model. return within spread doesn't seem end control flow. //post.js model /** * custom validator **/ types: { isuservalid: function(user_id) { var promise = require('bluebird'); promise.all([ user.findone({id: user_id}) ]) .spread(function(user) { console.log(user); if (user === null || user === undefined) { console.log('failed'); return false; }else{ console.log('passed'); return true; } }); } }, my response standard validation failed response. { "error": "e_validation", "status": 400, "summary": "1 attribute invalid", "model": "post", "invalidattributes": { "owner": [ { "rule": "isuservalid", ...
Read more

php - Find a regex to take part of Email -

i have following emails need extract part from: bestellnummer xxx: 1 von xxx, 1er pack ------------- anfang der nachricht ------------- foo bar baz foo bar baz // <<<<< need text here ------------- ende der nachricht ------------- ------------- anfang der nachricht ------------- foo bar baz foo bar baz ------------- ende der nachricht ------------- there 0 unlimited occurences of ------------- anfang der nachricht ------------- ------------- ende der nachricht ------------- and i'm able extract first part regex: $re = "/------------- .*? -------------.?(.*?).?------------- .*? -------------/s"; but, i'm quite new on learning regex, i'm pretty sure there must better regex extract part (foo bar baz foo bar baz) of text between ------------- anfang der nachricht ------------- ------------- ende der nachricht ------------- as can in different languages, i'm using .? to match between hyphens. i...
Read more