javascript - How to write repetitive [onClick] statements into single line in JQuery? -


how write following statements 1 line?

$("#pushkar").on("click", function () {         gula.hideunhide("#pushkardiv", "#pushkar", "#pushkar");     });     $("#rashkar").on("click", function () {         gula.hideunhide("#rashkardiv", "#rashkar", "#rashkar");     });     $("#kashkar").on("click", function () {         gula.hideunhide("#kashkardiv", "#kashkar", "#kashkar");     });     $("#fuskar").on("click", function () {         gula.hideunhide("#fuskardiv", "#fuskar", "#fuskar");     });     $("#ashke").on("click", function () {         gula.hideunhide("#ashkediv", "#ashke", "#ashke");     });

i have around 20 statements above , consuming lot of space.

i told stop repetition , make 1 line all; accumulate each button id.

is better strategy write in single line? not harms readability?

try this:

$("#pushkar, #rashkar, #kashkar, #fuskar, #ashke").on("click", function () {     var id = "#" + this.id;     gula.hideunhide(id + "div", id, id); });

btw, better keep common class. can this:

$(".commonclass").on("click", function () {     var id = "#" + this.id;     gula.hideunhide(id + "div", id, id); });

note: sending same argument twice seems unnecessary kept way only.

just suggestions you, there seems no need of passing 3 arguments. having single argument work great. example:

hideunhide(id){     var divid = id + "div";     // other code here }

and later in click events:

gula.hideunhide("#" + this.id);

Comments

Post a Comment

Popular posts from this blog

javascript - Google App Script ContentService downloadAsFile not working -

i have web app developed using google app script htmlservice , html form, populating excel sheet in google drive using spreadsheetapp . , 1 section calling contentservice download data excel file. function doget(e) { // read excel sheet //getappfile(); // render application html template return htmlservice.createtemplatefromfile('index').evaluate() .settitle('go smart') .setsandboxmode(htmlservice.sandboxmode.iframe); } function downloaddoublequatecsvfile() { var sheetid = propertiesservice.getscriptproperties().getproperty('sheetid'); var ss = spreadsheetapp.openbyid(sheetid).getactivesheet(); //var ss = spreadsheetapp.getactivespreadsheet().getactivesheet(); var maxcolumn = ss.getlastcolumn(); var maxrow = ss.getlastrow(); var data = ss.getrange(1, 1, maxrow, maxcolumn).getvalues(); if (data.length > 1) { var csv = ""; (var row = 0; row < data.length; row++) { (var c...
Read more

javascript - Function overwritting -

is there way overwrite function or event handling in function? using addeventlistener, can have many event handlers on element want var test=document.getelementbyid("div"); test.addeventlistener("click",function(){alert("im first");},false); test.addeventlistener("click",function(){alert("im second");},false); // alerts "im first" , after "im second" but if want overwrite function/event example based on client width example this function one() { alert("first"); } function two() { alert("second"); } window.onresize = function() { var test = document.getelementbyid("div"); if (window.innerwidth > 500) { test.onclick = 1 } else { test.onclick = two; } } is possible in javascript? in case use effective little known approach. addeventlistener can accept object property handleevent event handler. in case it's easy overwr...
Read more

php - Find a regex to take part of Email -

i have following emails need extract part from: bestellnummer xxx: 1 von xxx, 1er pack ------------- anfang der nachricht ------------- foo bar baz foo bar baz // <<<<< need text here ------------- ende der nachricht ------------- ------------- anfang der nachricht ------------- foo bar baz foo bar baz ------------- ende der nachricht ------------- there 0 unlimited occurences of ------------- anfang der nachricht ------------- ------------- ende der nachricht ------------- and i'm able extract first part regex: $re = "/------------- .*? -------------.?(.*?).?------------- .*? -------------/s"; but, i'm quite new on learning regex, i'm pretty sure there must better regex extract part (foo bar baz foo bar baz) of text between ------------- anfang der nachricht ------------- ------------- ende der nachricht ------------- as can in different languages, i'm using .? to match between hyphens. i...
Read more