How to DRY (myself) in Django form for Create and Edit Form -


i created 2 forms in django same model, named accountcreateform , accounteditform. account model has 3 fields , each of them has few form attributes such max_length, help_text, error_messages. example,

class accountcreateform(forms.modelform):     name = forms.charfield(max_length=50, required=true, label='account name', help_text='50 characters max', error_messages={'required': 'please enter account name'})     number = forms.charfield(max_length=16, required=true, label='phone number', help_text='10-16 digits max', error_messages={'required': 'please enter phone numbername'})

i want user able edit existing accounts well. so, added form editing purposes follow.

class accounteditform(forms.modelform):     name_error = { 'max_length': ("name should no longer 50 characters."), 'required': ("please enter account name")}     number_error = {'max_length': ("phone number should between 10-16 characters."),'min_length': ("phone number should between 10-16 characters."),'required': ("please enter phone number tied twilio account")}      name = forms.charfield(max_length=50, required=true, label='account name', help_text='50 characters max', error_messages=name_error)     number = forms.charfield(max_length=16, required=true, label='phone number', help_text='10-16 digits max', error_messages=number_error)

and template both account_create.html , account_edit.html share simple code this:

    <form method="post">         {% csrf_token %}         <p>         {% field in form %}             {{ field.errors }}             <label for="{{ field.id_for_label }}">{{ field.label }}({{ field.help_text }}):</label>             <br />             {{ field }}<br /><br />         {% endfor %}         </p>         <input class="btn btn-primary done-btn" type="submit" value="create new account">     </form>

it works fine , django helps provide error messages , texts fine. but, feel i'm repeating things here. tried approach suggested django documentation page this:

class accounteditform(forms.modelform):     class meta:         model = account         fields = ('name', 'number')         labels = {'name' : _('account name'), 'number': _('phone number')}         error_messages = {                 'name': {                     'max_length': _("name should no longer 50 characters."), 'required': ....}

and on. if intentionally left, name field, blank in edit form, django doesn't show error. way it'll show error seems first approach. there can improve code quality (that is, not repetitive)? thank you.

there can 2 ways accomplish this:-

1) make name field required inside model adding 'blank=false'.

    name = models.charfield(blank=false)

2) if don't want modify blank setting fields inside models (doing break normal validation in admin site), can following in form class:

def __init__(self, *args, **kwargs):     super(accounteditform, self).__init__(*args, **kwargs)      self.fields["name"].required = true

Comments

Post a Comment

Popular posts from this blog

c# - Validate object ID from GET to POST -

i have method allows user access comment have made on site. have post method lets them update comment. my normal solution send entire comment model through, let them update it, update on database when post back. involve sending commentid through in hiddenfor , can manipulated. how can verify commentid sent in get method same i'm getting in post , not able alter comment wish? how can verify commentid sent in method same i'm getting in post? basically have validate following things in post - user logged-in user. authenticated users post comments. commentid in post , should valid commentid , should present in database. userid associated logged-in user should same userid associated comment . comment should contain userid column, can check @ time of update. to make sure update happens comment has been sent in get - hold commentid in session , in post action compare commentid value in session .
Read more

node.js - Custom Model Validator SailsJS -

when using custom model validator checks record within model. return within spread doesn't seem end control flow. //post.js model /** * custom validator **/ types: { isuservalid: function(user_id) { var promise = require('bluebird'); promise.all([ user.findone({id: user_id}) ]) .spread(function(user) { console.log(user); if (user === null || user === undefined) { console.log('failed'); return false; }else{ console.log('passed'); return true; } }); } }, my response standard validation failed response. { "error": "e_validation", "status": 400, "summary": "1 attribute invalid", "model": "post", "invalidattributes": { "owner": [ { "rule": "isuservalid", ...
Read more

php - Find a regex to take part of Email -

i have following emails need extract part from: bestellnummer xxx: 1 von xxx, 1er pack ------------- anfang der nachricht ------------- foo bar baz foo bar baz // <<<<< need text here ------------- ende der nachricht ------------- ------------- anfang der nachricht ------------- foo bar baz foo bar baz ------------- ende der nachricht ------------- there 0 unlimited occurences of ------------- anfang der nachricht ------------- ------------- ende der nachricht ------------- and i'm able extract first part regex: $re = "/------------- .*? -------------.?(.*?).?------------- .*? -------------/s"; but, i'm quite new on learning regex, i'm pretty sure there must better regex extract part (foo bar baz foo bar baz) of text between ------------- anfang der nachricht ------------- ------------- ende der nachricht ------------- as can in different languages, i'm using .? to match between hyphens. i...
Read more