java - JUnit: Test exception doesn't work (AssertionError: Expected exception even if exception thrown) -


i'm trying test class exception. i've been trying couple different methods, nothing works. doing wrong here?

the class i'm trying test, primenumber.java:

public class primenumber {      static final logger log = logmanager.getlogger("log");      private string primenumberstr;      public primenumber(string primenumberstr) {         this.primenumberstr = primenumberstr;     }      public string getprimeresult() {         string resultstr = "";         try {             // convert user input int             int primenumberint = integer.parseint(primenumberstr);             // beginning of return message             resultstr += primenumberint + " ";             // add "not" if it's not prime             if (!primes.isprime(primenumberint))                 resultstr += "not ";             // end return message             resultstr += "a prime";             // if not valid number, catch         } catch (numberformatexception e) {             // log exception             log.warn("numberformatexception" + e.getmessage());             // if empty user input             if (primenumberstr.length() == 0)                 resultstr += "no number inserted";             // else not empty not valid             else                 resultstr += primenumberstr + " not valid number";             resultstr += ". numbers without decimals accepted.";         }          return resultstr;     }  }

and things i've tried test:

with annotation

@test(expected = numberformatexception.class) public void testnumberformatexceptionbeingthrown() {     primenumber primenumber = new primenumber("6dg");     primenumber.getprimeresult(); }

results in failed test and:

java.lang.assertionerror: expected exception: java.lang.exception

with junit rule:

@rule public expectedexception thrown = expectedexception.none();  @test(expected = numberformatexception.class) public void testnumberformatexceptionbeingthrown() {     thrown.expect(numberformatexception.class);     thrown.expectmessage("for input string: \"a21\"");     primenumber primenumber = new primenumber("a21");     primenumber.getprimeresult(); }

results in:

java.lang.assertionerror: expected test throw (an instance of java.lang.numberformatexception , exception message string containing "for input string: \"a21\"") @ org.junit.assert.fail(assert.java:88) @ org.junit.rules.expectedexception.failduetomissingexception(expectedexception.java:263) @ org.junit.rules.expectedexception.access$200(expectedexception.java:106) @ org.junit.rules.expectedexception$expectedexceptionstatement.evaluate(expectedexception.java:245) @ org.junit.rules.runrules.evaluate(runrules.java:20) @ org.junit.runners.parentrunner.runleaf(parentrunner.java:325) @ org.junit.runners.blockjunit4classrunner.runchild(blockjunit4classrunner.java:78) @ org.junit.runners.blockjunit4classrunner.runchild(blockjunit4classrunner.java:57) @ org.junit.runners.parentrunner$3.run(parentrunner.java:290) @ org.junit.runners.parentrunner$1.schedule(parentrunner.java:71) @ org.junit.runners.parentrunner.runchildren(parentrunner.java:288) @ org.junit.runners.parentrunner.access$000(parentrunner.java:58) @ org.junit.runners.parentrunner$2.evaluate(parentrunner.java:268) @ org.junit.runners.parentrunner.run(parentrunner.java:363) @ org.junit.runner.junitcore.run(junitcore.java:137) @ com.intellij.junit4.junit4ideatestrunner.startrunnerwithargs(junit4ideatestrunner.java:78) @ com.intellij.rt.execution.junit.junitstarter.preparestreamsandstart(junitstarter.java:212) @ com.intellij.rt.execution.junit.junitstarter.main(junitstarter.java:68) @ sun.reflect.nativemethodaccessorimpl.invoke0(native method) @ sun.reflect.nativemethodaccessorimpl.invoke(nativemethodaccessorimpl.java:62) @ com.intellij.rt.execution.application.appmain.main(appmain.java:140)

everything's working should. you've been able prevent methods throwing exceptions. you've been able test do throw exceptions.

it's just, doesn't make sense both @ same time. you need decide if want each method throw exception or not when given wrong arguments.

if do want method throw exception when given wrong argument, don't catch , handle exception, let thrown. then, test method throws exception, did above.

if don't want method throw exception when given wrong argument, decide want instead. then, test method want to. if throws exception, test fail.

that said, way handle numbers in class doesn't make sense. you're getting them strings, storing them strings, , returning them strings, whenever work them, convert them , forth ints. why not use int everywhere in first place?


Comments

Post a Comment

Popular posts from this blog

c# - Validate object ID from GET to POST -

i have method allows user access comment have made on site. have post method lets them update comment. my normal solution send entire comment model through, let them update it, update on database when post back. involve sending commentid through in hiddenfor , can manipulated. how can verify commentid sent in get method same i'm getting in post , not able alter comment wish? how can verify commentid sent in method same i'm getting in post? basically have validate following things in post - user logged-in user. authenticated users post comments. commentid in post , should valid commentid , should present in database. userid associated logged-in user should same userid associated comment . comment should contain userid column, can check @ time of update. to make sure update happens comment has been sent in get - hold commentid in session , in post action compare commentid value in session .
Read more

php - Find a regex to take part of Email -

i have following emails need extract part from: bestellnummer xxx: 1 von xxx, 1er pack ------------- anfang der nachricht ------------- foo bar baz foo bar baz // <<<<< need text here ------------- ende der nachricht ------------- ------------- anfang der nachricht ------------- foo bar baz foo bar baz ------------- ende der nachricht ------------- there 0 unlimited occurences of ------------- anfang der nachricht ------------- ------------- ende der nachricht ------------- and i'm able extract first part regex: $re = "/------------- .*? -------------.?(.*?).?------------- .*? -------------/s"; but, i'm quite new on learning regex, i'm pretty sure there must better regex extract part (foo bar baz foo bar baz) of text between ------------- anfang der nachricht ------------- ------------- ende der nachricht ------------- as can in different languages, i'm using .? to match between hyphens. i...
Read more

javascript - Function overwritting -

is there way overwrite function or event handling in function? using addeventlistener, can have many event handlers on element want var test=document.getelementbyid("div"); test.addeventlistener("click",function(){alert("im first");},false); test.addeventlistener("click",function(){alert("im second");},false); // alerts "im first" , after "im second" but if want overwrite function/event example based on client width example this function one() { alert("first"); } function two() { alert("second"); } window.onresize = function() { var test = document.getelementbyid("div"); if (window.innerwidth > 500) { test.onclick = 1 } else { test.onclick = two; } } is possible in javascript? in case use effective little known approach. addeventlistener can accept object property handleevent event handler. in case it's easy overwr...
Read more